Repository navigation
Perf metrics access fix for CB path - #4442
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a race in the continuous batching (CB) execution path where GenAI perf-metrics retrieval can throw/assert shortly after final output is produced, by retrying metrics access and only logging when metrics become available.
Changes:
- Add retry helpers (
tryGetPerfMetrics,tryGetVlmPerfMetrics) that catchov::Exceptionand yield briefly before retrying. - Update complete/partial response preparation to use the retry helpers and skip perf logging when metrics aren’t available yet.
- Add
<thread>includes to supportstd::this_thread::yield().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/llm/visual_language_model/continuous_batching/servable.cpp | Adds a retry wrapper around get_vlm_perf_metrics() and guards debug perf logging to avoid race-triggered failures. |
| src/llm/language_model/continuous_batching/servable.cpp | Adds a retry wrapper around get_perf_metrics() and guards debug perf logging to avoid race-triggered failures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
19
to
23
| #include <memory> | ||
| #include <stdexcept> | ||
| #include <string> | ||
| #include <thread> | ||
| #include <vector> |
Comment on lines
17
to
21
| #include <memory> | ||
| #include <stdexcept> | ||
| #include <string> | ||
| #include <thread> | ||
| #include <vector> |
dtrawins
approved these changes
Aug 10, 2026
michalkulakowski
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.