You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The new README is not merge-ready due to multiple placeholder blocks and inconsistent step numbering, and the skill metadata license field should be aligned with the repo license to avoid confusion.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new demo directory illustrating how to run short “DeepAgents Code” scenarios against OpenVINO Model Server, including local DeepAgents project assets for MCP SDK guidance and a verification subagent profile.
Changes:
Introduces a new demo README with end-to-end setup instructions and scenario prompts.
Adds project-local DeepAgents assets: an MCP SDK skill, an MCP tester subagent profile, and an MCP server config stub.
Adds a demo-scoped .gitignore for common local artifacts.
File summaries
File
Description
demos/integration_with_deepagents_code/README.md
Documents OVMS + dcode setup and a series of demo scenarios/prompts (currently includes placeholders and inconsistent step numbering).
demos/integration_with_deepagents_code/.gitignore
Ignores local virtualenv/log/output folders for the demo directory.
This section is titled “Step 2” even though the earlier numbered steps aren’t present (and “Step 3” appears above), so the document’s step ordering is inconsistent.
The validation instructions in AGENTS.md run python -m py_compile, which creates __pycache__ under the generated server directory. This ignore file does not exclude that bytecode, so each validation run adds generated artifacts to the demo's git working tree; add __pycache__/.
This MCP-task example repeats invalid dcode filesystem tool names (list_dir, grep_search, and file_search), so the command fails argument validation instead of starting. Use the actual names exposed by dcode's filesystem middleware.
execute is enabled and the shell allow-list includes python, python3, and timeout; these can run arbitrary Python or wrap another executable. As a result, this is not a safety boundary for an agent running on the host and can bypass the intended filesystem/tool restrictions. Run dcode in a real sandbox/container, or explicitly document that this command grants arbitrary host-code execution instead of presenting the list as command safety.
--trust-project-mcp skips DeepAgents Code's project-MCP approval gate and automatically trusts the committed stdio command, which executes the repo-controlled mcp_server/time_mcp_server.py. Running this from an untrusted checkout can therefore execute arbitrary Python before the user reviews the server; omit this bypass and have the user approve only time-server, or add a prominent warning to audit the project config and generated file first.
The only runtime check starts the script and waits for up to two seconds; it never performs MCP initialization or calls tools/list/tools/call. The 124 rule can therefore report PASS for a server that is hung, slow to initialize, or unable to serve tools, so this does not verify the runtime behavior claimed by the demo. Add a small MCP stdio readiness/tool-call probe, or narrow the claim to process startup.
- Run a short startup check: `timeout 2s python <server_path>`.
The required time tool returns the current time, but this quality rule requires all outputs to be deterministic. Those instructions conflict and can lead the agent to freeze or mock the timestamp. Require a stable machine-readable format/schema instead, while explicitly allowing the time value to vary.
- Keep tool outputs deterministic and machine-readable.
The Qwen3.8-27B model used here is documented in demos/continuous_batching/speculative_decoding/README.md:29 as requiring OVMS 2026.4 or a weekly build, but these commands use the floating latest-gpu tag. On hosts whose tag predates that support, the model deployment will fail; use an explicit compatible tag or state and enforce the required OVMS version consistently for all five commands.
The MCP server script is missing. Ask the agent to create it using the project skill located at `.deepagents/skills/python-mcp-sdk-skill/SKILL.md`. Invoking a skill with `/skill:<name>` gives the agent a focused, tested recipe instead of relying on generic knowledge:
This link targets the generic deployment page with a fragment that does not exist; the bare-metal page is a separate generated page (docs/deploying_server_baremetal.md, anchor ovms_docs_deploying_server_baremetal). As written, the Windows installation prerequisite does not take users to the referenced guide. Link directly to https://docs.openvino.ai/2026/model-server/ovms_docs_deploying_server_baremetal.html.
The --rubric does not require the new date tool to carry the read-only annotations required by SKILL.md. A rubric-compliant implementation can add a plain @mcp.tool, pass this headless step, and then fail Step 7 with the documented approval error; require readOnlyHint=true and destructiveHint=false for the new tool here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
https://openvino-doc.iotg.sclab.intel.com/deepagents-integration-demo/model-server/ovms_demos_integration_with_deepagents_code.html
🧪 Checklist
``