Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The pinned GenAI revision contains the required notification-ordering fix, and both call paths are updated consistently.
Review effort: Balanced
Findings: None
What changed in this PR
Removes obsolete OVMS polling now that GenAI publishes performance metrics before notifying generation consumers.
Changes:
- Removes retry/yield helpers and unused thread headers.
- Retrieves and logs LLM/VLM metrics directly.
| File | Description |
|---|---|
src/llm/language_model/continuous_batching/servable.cpp |
Simplifies LLM metrics retrieval. |
src/llm/visual_language_model/continuous_batching/servable.cpp |
Simplifies VLM metrics retrieval. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
przepeck
approved these changes
Oct 1, 2026
michalkulakowski
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized in GenAI, don't need special treatment in OVMS anymore