Skip to content

Fix issue when targeting a patch version for serialization #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GleasonK merged 2 commits into from
Oct 23, 2024
Merged

Fix issue when targeting a patch version for serialization #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0838e55
Fix issue when targeting a patch version for serialization
GleasonK Oct 22, 2024
898f32d
typo fix
GleasonK Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions stablehlo/tests/vhlo/vhlo_to_version_downgrade_patch.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: stablehlo-opt --stablehlo-legalize-to-vhlo --vhlo-to-version='target=1.4.1' %s | FileCheck %s

// AllToAll was in the initial StableHLO opset, but changed in v1.5.0 to have
// tuple arguments. Ensure that serializing for 1.4.1 is valid and targets the
// v1.4.0 opset.
//
// This will catch issues in op `isLegal` checks:
// op.minVersion() <= target <= op.maxVersion()

// CHECK-LABEL: vhlo.func_v1 @all_to_all
func.func public @all_to_all(%arg0: tensor<8x8x1xui16>) -> tensor<1x8x8xui16> {
// CHECK: vhlo.all_to_all_v1
%0 = "stablehlo.all_to_all"(%arg0) <{concat_dimension = 2 : i64, replica_groups = dense<[[0, 1, 2, 3, 4, 5, 6, 7]]> : tensor<1x8xi64>, split_count = 8 : i64, split_dimension = 0 : i64}> : (tensor<8x8x1xui16>) -> tensor<1x8x8xui16>
return %0 : tensor<1x8x8xui16>
}
7 changes: 7 additions & 0 deletions stablehlo/transforms/VhloToVersion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ FailureOr<Version> validateTargetVersion(llvm::StringRef versionRef,
<< " is greater than current version "
<< Version::getCurrentVersion();

// Opset changes warrant a minor version bump, so this conversion assumes
// patch v0 since it is written against the opset at version `X.Y.0`.
if (targetVersion.getPatch() != 0) {
targetVersion =
vhlo::Version(targetVersion.getMajor(), targetVersion.getMinor(), 0);
}

return targetVersion;
}

Expand Down
Loading