Skip to content

feat(actor-classifier): wire registerBotId() boot call for KNOWN_BOT_IDS #105

Description

@optemism

Context

PR #104 (refactor-actor-classifier) exports registerBotId(id) and makes KNOWN_BOT_IDS private, which is the safe API shape. However, nothing calls registerBotId() at boot, so the Set stays empty at runtime and bot detection via KNOWN_BOT_IDS never fires.

What's needed

  1. Decide the source of truth for integration/bot IDs to register — options:

    • Hardcoded list in config (simplest — IDs rarely change)
    • Notion DB property (fetched at startup)
    • Environment variable
  2. Add a boot call (e.g., in src/config.js or app entry) that calls registerBotId() for each known bot ID.

  3. Add a test that verifies the boot call populates the Set correctly.

Why it matters (P1)

Without boot wiring, a Notion integration that presses a button and has a source.user_id present but no source.type: 'bot' will be classified as a person (mentionable: true), generating spurious Notion mention notifications.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions