Repository navigation
Fix/per block runtime decoding - #7
Merged
Merged
Conversation
…shield commitment on every path
…nt records and block info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 0.7.1, with no API changes.
getDynamicBuilder(blockHash?)andgetExtrinsicDecoder(blockHash?)fetch the metadata of the runtime a block executed under, over RPC, once perspec_version.queryBlockEventspasses its hash. Before, the metadata cached at connect decoded every block, so at spec 17 every earliershieldmisdecoded, and a long-lived session misdecoded blocks after an upgrade. Without a hash, behaviour is unchanged.assertShieldParamsrequires a 32-byte hex commitment. The pallet call now refuses what the precompile calldata already refused.SubstrateClientis split by responsibility.runtimeDecoders: metadata and decoders per runtime. Each decoder is built on first use, and a failed fetch is retried instead of cached.eventRecords:System.Events→EventRecord.blockInfo: block time fromtimestamp.setand author from the digest.getBlockis split intoresolveBlockHashandreadTimestamp.extractAuthorFromLogsand theDynamicBuilder/ExtrinsicDecodertypes are still exported fromSubstrateClient.Test plan
pnpm run check: 899 passedpnpm audit: no known vulnerabilitiespnpm pack --dry-run