feat: add Kanidm OIDC support with PKCE and ID token algo config#682
Open
mikimandoki wants to merge 1 commit into
Open
feat: add Kanidm OIDC support with PKCE and ID token algo config#682mikimandoki wants to merge 1 commit into
mikimandoki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While I was attempting to set up Kanidm to work with SplitPro I had hit a few roadblocks:
Kanidm includes an
issued_token_typefield in its token response which isn't in the Prisma schema, causing a DB crash before the account could be created. Rather than adding another provider-specific case tolinkAccount, this PR replaces the entire chain with a generic sanitisation pass usingPrisma.AccountScalarFieldEnumas the source of truth. Any provider with non-standard fields now works without further changes.Kanidm also enforces PKCE and ES256 by default, both of which were previously not supported by SplitPro. These can now be configured by optional env vars. I also added an example kanidm env config.
To test these changes, I ran the updated code on my NAS in a Docker container and finally managed to authenticate with Kanidm. Disabling PKCE or defaulting to RS256 both fail on the default Kanidm config.
Checklist
CONTRIBUTING.mdin its entirety