Skip to content

v1.29.0 dry-run: flip switch-on feature flags to default - #870

Draft
mzihlmann wants to merge 8 commits into
mainfrom
v1.29.0-dry-run
Draft

v1.29.0 dry-run: flip switch-on feature flags to default#870
mzihlmann wants to merge 8 commits into
mainfrom
v1.29.0-dry-run

Conversation

@mzihlmann

@mzihlmann mzihlmann commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Do not merge. Dry-run to surface v1.29.0 regressions in CI ahead of the release, since last time issues only showed up just before cutting the release.

Graduates the feature flags due in v1.29.0 per the lifecycle in docs/releases.md. Activated flags default to true now and are slated for removal in v1.30.0. The v1.28.0-activated flags are removed and their behavior is now unconditional.

Flag Change
FF_KANIKO_SKIP_WRITE_WHITEOUTS activate
FF_KANIKO_INFER_CROSS_STAGE_CACHE_KEY activate
FF_KANIKO_REPRODUCIBLE_PRESERVE_BASE_LAYERS activate
FF_KANIKO_RESOLVE_CACHE_KEY activate
FF_KANIKO_SKIP_RELABEL_RECOMPRESS activate
FF_KANIKO_UNTAR_SKIP_ROOT activate
FF_KANIKO_RUN_MOUNT_BIND remove, behavior now unconditional
FF_KANIKO_NO_PROPAGATE_ANNOTATIONS remove, behavior now unconditional
FF_KANIKO_VOLUME_SKIP_MKDIR remove, behavior now unconditional
FF_KANIKO_PRESERVE_HARDLINKS remove, behavior now unconditional
FF_KANIKO_BUILDKIT_ARG_ENV_PRECEDENCE remove, behavior now unconditional
FF_KANIKO_PRESERVE_MOUNTED_PATHS remove, behavior now unconditional
FF_KANIKO_DEPRECATE_INTER_STAGE_RESTORE remove, behavior now unconditional
FF_KANIKO_SECUREJOIN_EXTRACTION remove, behavior now unconditional
FF_KANIKO_WARMER_CACHE_LOCK remove, behavior now unconditional
FF_KANIKO_CLEAN_KANIKO_DIR remove, behavior now unconditional
FF_KANIKO_OCI_WARMER remove, ocilayout warmer now unconditional, tarball path deleted
FF_KANIKO_IGNORE_CACHED_MANIFEST remove, obsoleted by the ocilayout warmer
FF_KANIKO_RUN_VIA_TINI defer to v1.30.0, once the tini binary ships for RISC-V

FF_KANIKO_RUN_VIA_TINI stays default off, held back until the tini binary ships for RISC-V. It is the only switch-on flag not flipped here. The --image-format=oci default flip lives in #850 and is not on main yet, so it is out of scope for this branch.

FF_KANIKO_NO_PROPAGATE_ANNOTATIONS is fully retired. Base image annotations are already stripped unconditionally by WithoutAnnotations before a stage is built, so the mz507 base-annotation workaround in newStageBuilder is now redundant and dropped. baseImageDigest is unchanged, since Manifest.Annotations is omitempty and the stripped image already carries none.

FF_KANIKO_OCI_WARMER removal deletes the legacy tarball Warmer path, its unit tests, and the .json manifest sidecar cleanup. The warmer now always writes an ocilayout. FF_KANIKO_IGNORE_CACHED_MANIFEST was only a workaround for the tarball writer rewriting the manifest mediatype, which the ocilayout format fixes at the root, so it goes too.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.79661% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/util/fs_util.go 47.61% 7 Missing and 4 partials ⚠️
pkg/warmer/warm.go 42.85% 5 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 07e3a6f5-1271-4b69-8947-34d97b196202

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v1.29.0-dry-run

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant