run the integration suite against docker 29.6.1 - #917
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe integration workflow now uses Docker 29.7.0. Integration image tests use shared Docker v2 BuildKit flags, cover stop-signal and healthcheck cases, and ignore an expected directory-mode difference. ChangesDocker compatibility updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5f8bd2f to
ca933e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d839854 to
6778b9a
Compare
6778b9a to
6469c8a
Compare
10fc3bd to
cb7e26c
Compare
docker 29.5.2 is the last version where
--provenance=falsealone gets buildkit to emit a dockerv2 manifest. On 29.6.1 that flag only drops the attestation and leaves an OCI manifest behind, so every test whose oracle has to match a dockerv2 image kaniko produced started diverging on the manifest format. The mediatype is now selected explicitly with--output=type=image,oci-mediatypes=false. provenance stays off next to it because buildkit refuses to export attestations once docker mediatypes are pinned.The bump also exposes mz922 in
Dockerfile_test_copyadd_chmod. buildkit now appliesADD --chmodto the destination directory it creates, kaniko still subtracts the umask there, so/dir777comes out 0755 against docker's 0777. That divergence is ignored per test until mz922 is fixed.Summary by CodeRabbit
Tests
Chores