mz960: don't squash a base stage that declares ONBUILD - #964
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2c12076 to
687c2ab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes #960
Squashing filters the base stage's ONBUILD declaration out of the merged command list. That is fine for the squash in MakeKanikoStages, which runs before any cache key exists, but the stage elimination behind FF_KANIKO_SKIP_CACHED_STAGES squashes after the lookahead has already hashed the unsquashed chain. The merged chain then hashes one command fewer, so every key after the ONBUILD diverges from the precomputed one. On a cache-consume build the inferred cross-stage key misses, the COPY --from falls back to hashing its source files, and the build aborts because the stage it reads from was eliminated and never wrote /kaniko/deps/N. So we leave a base stage that declares an ONBUILD unsquashed, it stays alive and writes its deps like it does with the flag off.