FROZEN. feature: add ims logo - #7
Closed
MksmOrlov wants to merge 1 commit into
Closed
Conversation
MikhailSadovsky
requested changes
Jan 17, 2024
| <div className={className}> | ||
| <div className={styles.sideBarContent}> | ||
| <div className={styles.searchFieldWrap}> | ||
| <LogoIMS className={styles.logo} /> |
Collaborator
There was a problem hiding this comment.
I suggest to add logic for logo click like it was added here
Collaborator
There was a problem hiding this comment.
Please update title in index.html as well
| [styles.accordionContent_admin]: !!user?.is_admin, | ||
| })} | ||
| > | ||
| <div className={styles.accordionContent_admin}> |
Collaborator
There was a problem hiding this comment.
I suggest to leave logic as it was without possibility to change sections
| leftIcon={<Sections />} | ||
| rightIcon={!!user?.is_admin || !!user?.can_edit ? <Plus /> : null} | ||
| rightIcon={<Plus />} | ||
| onRightClick={onAddClick} |
Collaborator
There was a problem hiding this comment.
Please leave as it was
|
|
||
| const requests = useSelector(selectRequests); | ||
|
|
||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
Please leave as it was for now
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| display: grid; | |||
Collaborator
There was a problem hiding this comment.
smth wrong with styles. Logo should be in same level as en/ru languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frozen reason: this logic exists here #3
Copy from https://github.com/ostis-ai/react-sc-web-old/pull/6