AO3-7210 I18n skins-creating.html help file #5554
Conversation
|
Styling: When in a modal, the skins-creating page is in a context where rules like |
that's a problem with all new help pages (and not the only problem either), i think the ad&t are still deciding what to do about it, so you don't need to do anything right now. i'm expecting there will be a new issue or several in the future for this |
Bilka2
changed the title
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Thanks for working on this complicated file!
| t(".numeric_values.description.various_units"), | ||
| "https://w3schools.com/css/css_units.asp" | ||
| ) | ||
| ) %><br /><code>cm, em, ex, in, mm, pc, pt, px</code></p> |
There was a problem hiding this comment.
I think this list should be entirely in the locale file, since we need to be able to localise the comma, as it's a sentence, not CSS. And language like Chinese use a different comma character. Ideally this should be part of the precision_html string, if possible
| <p><%= t( | ||
| ".scale.description_html", | ||
| transform_code: tag.code("transform"), | ||
| scale_numeric_value_code: tag.code("scale(#{t('.scale.numeric_value')})") |
There was a problem hiding this comment.
I'm wondering whether it would be better to have the entire scale(numeric value) be in the locale file, not just numeric value. But I can't really come up with a reason for it other than this looking quite strange, which isn't enough of a reason to make you change it
There was a problem hiding this comment.
It does look kinda weird, but since scale is an actual CSS keyword and not an example term I figured it belonged in the code instead of the localization. I'm fine with it either way though, just let me know if you want it changed.
Bilka2
changed the title
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
| units_list_code: tag.br + tag.code(t(".numeric_values.description.units_list", | ||
| cm_code: "cm", | ||
| em_code: "em", | ||
| ex_code: "ex", | ||
| in_code: "in", | ||
| mm_code: "mm", | ||
| pc_code: "pc", | ||
| pt_code: "pt", | ||
| px_code: "px"))) %> |
There was a problem hiding this comment.
I would prefer to have the units in the locale file so that the string isn't so split up
| <dd> | ||
| <p> | ||
| <%= t(".css_basics.description.line_of_css_html", | ||
| example_css_code: tag.code("#{t('.css_basics.description.selector')} {#{t('.css_basics.description.property')}: #{t('.css_basics.description.value')};}")) %> |
There was a problem hiding this comment.
I would prefer to have the entire thing, including the {} and semicolon, in the locale file, instead of splitting the string this much
3 participants
Issue
https://otwarchive.atlassian.net/browse/AO3-7210
Purpose
Migrates the static
skins-creating.htmlhelp file to a localized view on the help controller.