Skip to content

fix: type-check ci #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysknsid25 merged 2 commits into from
Oct 20, 2026
Merged

fix: type-check ci #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cfb683
fix: type-check ci
ysknsid25 Oct 20, 2026
20cc496
fix: type-check ci
ysknsid25 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/eslint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: 'Tests: ESLint'

on: [pull_request, push]
on:
pull_request:
push:
branches:
- master

permissions:
contents: read
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/lint-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: 'CI: lint & build'

on: [pull_request, push]
on:
pull_request:
push:
branches:
- master

permissions:
contents: read
Expand Down
31 changes: 15 additions & 16 deletions .github/workflows/type-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,30 @@
name: "Types: check published types"

on: [pull_request, push]
on:
pull_request:
push:
branches:
- master

permissions:
contents: read

jobs:
test:
name: ESLint ${{ matrix.eslint_version }}, TS ${{ matrix.ts_version }}, "${{ matrix.ts_lib }}"
name: ESLint ${{ matrix.eslint_version }}, TS ${{ matrix.ts.version }}, "${{ matrix.ts.lib }}"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
eslint_version:
- 9
- 10
# the oldest and the newest TS / lib, and the DOM lib (whose globals can conflict with the types)
# ESLint 9+ ships types via @eslint/core which requires TS >= 5.0
ts_version:
- '5.0'
- 5.5
- 5.6
- '6.0'
ts_lib:
- es2015
- es2015,dom
- es2020
- esnext
ts:
- { version: '5.0', lib: es2015 }
- { version: '6.0', lib: 'es2015,dom' }
- { version: '6.0', lib: esnext }
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand All @@ -47,14 +46,14 @@ jobs:
run: echo "ESLINT_PLUGIN_REACT_PATH=$(ls "$RUNNER_TEMP"/ysknsid25-eslint-plugin-react-*.tgz | tail -n 1)" >> "$GITHUB_ENV"

# test-published-types is a separate package, not part of this repository's pnpm workspace
- name: install @ysknsid25/eslint-plugin-react, eslint ${{ matrix.eslint_version }} and typescript ${{ matrix.ts_version }}
run: pnpm add --ignore-workspace "$ESLINT_PLUGIN_REACT_PATH" "eslint@^${{ matrix.eslint_version }}" "typescript@${{ matrix.ts_version }}"
- name: install @ysknsid25/eslint-plugin-react, eslint ${{ matrix.eslint_version }} and typescript ${{ matrix.ts.version }}
run: pnpm add --ignore-workspace "$ESLINT_PLUGIN_REACT_PATH" "eslint@^${{ matrix.eslint_version }}" "typescript@${{ matrix.ts.version }}"
working-directory: test-published-types

- name: show installed versions
run: pnpm list --ignore-workspace --depth=0
working-directory: test-published-types

- name: check types with lib "${{ matrix.ts_lib }}"
run: pnpm exec tsc --lib ${{ matrix.ts_lib }}
- name: check types with lib "${{ matrix.ts.lib }}"
run: pnpm exec tsc --lib ${{ matrix.ts.lib }}
working-directory: test-published-types
Loading