Conversation
Instead of type=bool, use action='store_true'. This means you use --include-coordinator instead of --coordinator=true; --coordinator is renamed to --include-coordinator and --mentor is renamed to --include-mentor for clarity.
Example: ./emailmentors.py testemail_out testemail_body testemail_contacts # check that the mails in testemail_out look OK SMTP_USER=<user> SMTP_PASSWORD=<password> ./emailmentors.py testemail_out testemail_body testemail_contacts --smtp-server mail.outreachy.org --smtp-ssl --smtp-login
Specify the organizer on the command line rather than hardcoding Sage Sharp.
Make it so that you have to specify at least one of --include-mentor, --include-intern, or --include--coordinator.
…ling Build the message as a EmailMessage rather than writing out a string directly. This results in RFC-correct encoding of headers and the body. We need this when sending the message out over SMTP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection of loosely related patches that a) generalize emailmaintainers.py, b) rename it to emailparticipants.py c) add the ability to send the result directly out via SMTP, since not all mail clients have any easy way to send a directory full files as a set of emails. I worked on figuring out what changes where useful for this together with @marinaz.