Intl: accept legacy IANA primary zones (CET, CST6CDT, EET, EST5EDT, MET, MST7MDT, PST8PDT, WET)#227
Open
robobun wants to merge 1 commit into
Open
Intl: accept legacy IANA primary zones (CET, CST6CDT, EET, EST5EDT, MET, MST7MDT, PST8PDT, WET)#227robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Jun 16, 2026 in 12m 49s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | Source/JavaScriptCore/runtime/IntlObject.cpp:1954-1958 |
Comment claims zones are primary IANA Zones in etcetera, but tzdata 2024b moved them to backward as Links |
Annotations
Check warning on line 1958 in Source/JavaScriptCore/runtime/IntlObject.cpp
claude / Claude Code Review
Comment claims zones are primary IANA Zones in etcetera, but tzdata 2024b moved them to backward as Links
The comment states these identifiers "are first-class `Zone`s in the IANA `etcetera` file (not backward links)", but as of tzdata 2024b (Sep 2024) all eight were moved out of `etcetera` and are now `Link` entries in the `backward` file. The code change is still correct — test262/ECMA-402 require these to be accepted regardless — but consider rewording the rationale to e.g. "legacy POSIX-style IANA identifiers required by ECMA-402/test262" so the comment doesn't go stale against current IANA data
Loading