fix(cdn): prevent log streaming stall in sendStepLog#7644
Open
fix(cdn): prevent log streaming stall in sendStepLog#7644
Conversation
Replace break with continue when scoreNextLineToSend does not match the current line number. When lines arrive out of order in the Redis buffer, the old break would exit the loop and never re-trigger an update, causing the stream to stall permanently. Added gap recovery: when lines exist in the buffer but none match the expected scoreNextLineToSend, jump to the first available line and re-trigger an update instead of staying stuck forever. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fsamin
requested review from
richardlt,
sguiheux and
yesnault
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace break with continue when scoreNextLineToSend does not match the current line number. When lines arrive out of order in the Redis buffer, the old break would exit the loop and never re-trigger an update, causing the stream to stall permanently.
Added gap recovery: when lines exist in the buffer but none match the expected scoreNextLineToSend, jump to the first available line and re-trigger an update instead of staying stuck forever.