feat(ovhcloud-cli): migrate file storage share endpoints to v2 - #278
Merged
Conversation
Bxota
marked this pull request as draft
September 4, 2026 11:40
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
from
September 4, 2026 11:54
970a170 to
f616e8b
Compare
Bxota
marked this pull request as ready for review
September 4, 2026 11:55
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
2 times, most recently
from
September 4, 2026 12:59
13ff9e5 to
3c1f3b3
Compare
amstuta
reviewed
Sep 7, 2026
Bxota
marked this pull request as draft
September 7, 2026 08:10
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
from
September 7, 2026 09:48
908fd2f to
abcc5ad
Compare
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
from
September 7, 2026 09:50
abcc5ad to
20b2967
Compare
Bxota
marked this pull request as ready for review
September 7, 2026 09:59
amstuta
reviewed
Sep 8, 2026
| --init-file string Create a file with example parameters | ||
| --name string Share name | ||
| --network-id string Network ID | ||
| --protocol string Share protocol |
Collaborator
There was a problem hiding this comment.
it would be worth mentioning the available values that can be fed here, and have a default value (only NFS for now, so a good default). Same comment for the share-type flag that should default on STANDARD_1AZ
Contributor
Author
There was a problem hiding this comment.
Documentation up default value for :
- share-type
- protocol
Collaborator
There was a problem hiding this comment.
I don't see this change in the cobra command declaration, could you add it and re-run make doc ?
Contributor
Author
There was a problem hiding this comment.
make doc already done, is everything ok ?
amstuta
reviewed
Sep 8, 2026
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
from
September 8, 2026 07:59
20b2967 to
5208f08
Compare
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
Bxota
force-pushed
the
dev/tleterme/migrate-file-storage-v2
branch
from
September 8, 2026 08:03
5208f08 to
26b8601
Compare
Signed-off-by: Thomas Leterme <thomas.leterme@corp.ovh.com>
amstuta
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate Cloud File Storage share commands from the v1 API to the v2 API.
The migration updates the create, list, get, edit, and delete operations to use the v2
/publicCloud/project/{projectId}/storage/file/shareendpoints. It also updates the request payload structure, OpenAPI schema, parameter example, output template, and generated documentation.This also adds create, list, get and delete operations to use
/publicCloud/project/{projectId}/storage/file/networkendpoints. These points are necessary to use the new endpoints above.ACL and Snapshot endpoints are intentionally excluded from this change.
Type of change
Checklist:
go mod tidy