Conversation
Signed-off-by: David Walter <d@amamus.net>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the maintained Office example with the current
ocis_fullsuite-selection pattern:enabledfieldsThe chart intentionally supports multiple collaboration providers. Since each provider's MIME types are discovered at runtime, Helm cannot determine whether enabled suites overlap. The warning therefore preserves advanced disjoint-format deployments while making the interlocking risk explicit instead of rejecting every multi-provider configuration.
Changed Files
deployments/ocis-office/helmfile.yamlandREADME.mdcharts/ocis/templates/NOTES.txtcharts/ocis/values.yamlcharts/ocis/values.schema.jsonand AsciiDoc values referencesRelated Issue
Motivation and Context
The example registered Collabora and OnlyOffice simultaneously even though the maintained source profile enables Collabora and leaves OnlyOffice disabled. oCIS does not currently coordinate application locks for the same file across suites, so users can be unable to open or edit a file in one suite until another suite releases its lock.
There is no commit dependency on another alignment PR. PR #965 updates dependency and image versions in earlier sections of the same Helmfile; a clean virtual merge retained both changes and passed focused Helmfile lint.
The exhaustive CI values fixture deliberately keeps both providers enabled to preserve coverage of the chart's supported multi-provider rendering path. It is not a deployment recommendation; the focused release-notes test exercises both the warned multi-suite case and safe one-suite case.
How Has This Been Tested?
DemoCollabora; strict Kubernetes 1.31 validation passed for all 101 resourcesScreenshots (if appropriate):
Not applicable.
Types of changes
Checklist: