perf(linter): compute apply_overrides rule set lazily#23648
Open
shulaoda wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config::apply_overridesis called for every linted file. It eagerly builtall_rulesby filtering and cloning every entry inRULES(~837 rules) into aVecon each call.But
all_rulesis only used when an override introduces a new, unconfigured plugin (to apply that plugin's category rules). In the common case — overrides that only tweak rule severities for certain file globs — it was computed and never used, cloning ~837 rules per file for nothing.This computes
all_ruleslazily (Option<Vec<RuleEnum>>+get_or_insert_with), so it is only built when a new plugin actually requires it, and reused across override iterations exactly as before. Behavior is unchanged.Both code paths are covered by existing tests: the common path (
test_remove_rule,test_change_rule_severity, …) and the lazy path (test_categories_only_applied_to_new_plugins_not_in_root,test_categories_not_reapplied_to_root_plugins, …).