Open
Conversation
erikdubbelboer
commented
Jan 4, 2019
| var ( | ||
| msg string | ||
| out BufferOut | ||
| ) |
Author
There was a problem hiding this comment.
Why were these even global variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the ones I found so far I'm pretty sure these aren't the only race conditions. One major issue is that a lot of state is mutated in goroutines while the whole state is then read and serialized by the web server. For this reason I have added the mutex in the Realize struct as there is no other level on which this could easily be fixed.