Add instance to anti-affinity group in create form#2788
Add instance to anti-affinity group in create form#2788benjaminleonard wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| apiQueryClient.prefetchQuery('currentUserSshKeyList', {}), | ||
| apiQueryClient.prefetchQuery('projectIpPoolList', { query: { limit: ALL_ISH } }), | ||
| apiQueryClient.prefetchQuery('floatingIpList', { query: { project, limit: ALL_ISH } }), | ||
| apiQueryClient.prefetchQuery('antiAffinityGroupList', { |
There was a problem hiding this comment.
Number of groups is likely to be low. Curious if there is a threshold where its better to move this stuff after the page is loaded.
|
What if the combobox was inline instead of in a modal? |
|
Worth a try, but we would need to change the floating IPs one also |
|
There's a few other things on that, e.g. do we do that for attach disks also? Do we stack the listbox and button (like firewall rules)? For now I'd say we defer that, since I've been trying to figure out a minitable and integrated input pattern for the webhooks work and also solve confusion around fields not being added in the firewall rules modal. |
|
I think this works as it is, and we can swap out for integrated mini table when that work is done. Just fixed the conflicts and improved the minitable and add button. |
2 participants
Configuration might not be the best place in the advanced accordion to put it, but not sure if it justifies its own section. Added to the
instanceCreatehandler and a e2e test.