Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paudmir
requested review from
david-crespo
and removed request for
david-crespo
david-crespo
changed the title
Collaborator
|
PRETTY COOL 
|
Collaborator
|
It all seems to work pretty well. How do you think we should consume the coverage reports @paudmir? We can generate the report in CI and make it available on any PR. We could go even farther and have CI fail if a PR causes coverage to drop. A middle ground would be to just track coverage for a while and make it easy to see the effect of a given PR on coverage. Looks like we can probably use https://about.codecov.io/ for free because the repo is public. I'll try it. |
Author
|
@david-crespo I think tracking it for a while would be good, and add tests to cover what is missing, which I think will mostly be making things fail on purpose😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to clean the mess I have while I was testing different things, so I can't guarantee that this is going to work right away yet it's on the right path 😄
I did install these packages:
npm install v8-to-istanbul npm install babel-plugin-Istanbul npm install monocartI have a hunch that the monocart one might not be necessary to run what is out there.
With these, one just needs to run the playwright tests as usual (just gotta point the
testmodule to the one in thefixtures.tsso that the code coverage can run).e.g. npm run e2ec -- action-menu
This should generate a
.nyc_outputfolder with non-emptycoverage.jsonfile.To generate the HTML so you can see the report, you'll need to run this command:
npx nyc report --reporter=htmlA report would look like this:
PS. THIS IS JUST AN EXAMPLE/guide, so not intended to be deployed @david-crespo