Add an operationId strategy to reject or ignore missing operations#1194
Open
arlyon wants to merge 4 commits intooxidecomputer:mainfrom
Open
Add an operationId strategy to reject or ignore missing operations#1194arlyon wants to merge 4 commits intooxidecomputer:mainfrom
arlyon wants to merge 4 commits intooxidecomputer:mainfrom
Conversation
arlyon
changed the title
arlyon
force-pushed
the
arlyon/missing-opid-strategy
branch
2 times, most recently
from
e6f31b6 to
edecb25
Compare
New changes to cargo means in recent rust (1.91) means that this does not always find the bin properly. A deprecation notice recommends a compile-time macro instead which does find it.
arlyon
force-pushed
the
arlyon/missing-opid-strategy
branch
from
edecb25 to
090b80b
Compare
Author
|
Added another variant |
arlyon
force-pushed
the
arlyon/missing-opid-strategy
branch
from
b4213f0 to
636baea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply adds a flag to ignore operations with missing ids rather than rejecting them outright. Routes for which progenitor cannot determine a name can be ignored. The default behaviour is not affected. I added a snapshot to exercise the codepath.