This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Draft
Conversation
added 2 commits
November 30, 2021 12:17
Adds "_traceparent" to Cacher's hardware data structure so we can do in-band propagation of traceparent between API and boots. Signed-off-by: Amy Tobey <atobey@equinix.com>
When signaling in-band my preference is to lead with an underscore so it's fairly clear it's not app data, but since the Otel injectors insist on setting their own 'traceparent' key we'll just use that. Signed-off-by: Amy Tobey <atobey@equinix.com>
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 5 5
Lines 620 620
=======================================
Hits 276 276
Misses 334 334
Partials 10 10
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a traceparent field to hardware records. There's an open PR to have the API service add the traceparent as an in-band key on the hardware data it pushes to cacher in addition to propagating via gRPC. The idea here is that the in-band value will be available to boots when it comes and fetches the hardware record, and can continue the trace.