Skip to content

Conversation

@Madmadness65
Copy link
Member

@Madmadness65 Madmadness65 commented Nov 11, 2025

What are the changes the user will see?

This adds the Aroma Lady, Bird Keeper, Bug Catcher, Camper, Collector, Dragon Tamer, Fairy Tale Girl, Interviewers, Mysterious Sisters, Ruin Maniac, Scuba Diver, Snow Ace Trainer, and Young Couple trainer types to the game. With the addition of the Scuba Diver trainer type, random trainers are now permitted in the Seabed biome again at a 1/16th chance.

Note that biome placement, species pools, and species filters for new trainer types are not yet finalized.

Why am I making these changes?

More unique trainer types were desired to fill out specific biomes that lacked trainer types, preferably in the Common tier.

What are the changes from a developer perspective?

New trainer type data has been added, which includes enum entries, dialogue entries, biome placement, and (currently temporary) trainer config data

Screenshots/Videos

New Trainer Types
Aroma Lady image
Bird Keeper image image-1
Bug Catcher image
Camper/Picnicker image image
Collector image
Dragon Tamer image
Fairy Tale Girl image
Interviewers image
Mysterious Sisters image
Ruin Maniac image
Scuba Diver/Free Diver image image
Snow Ace Trainer image image
Young Couple image

How to test the changes?

Set BATTLE_TYPE_OVERRIDE to BattleType.TRAINER and set RANDOM_TRAINER_OVERRIDE to whatever trainer you want to test, such as {trainerType: TrainerType.AROMA_LADY}.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (pnpm test:silent)
    - [ ] Have I created new automated tests (pnpm test:create) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    - [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

Does this require any changes to the assets folder? If so:

This adds the Aroma Lady, Bird Keeper, Bug Catcher, Camper, Collector, Dragon Tamer, Fairy Tale Girl, Interviewers, Mysterious Sisters, Ruin Maniac, Scuba Diver, Snow Ace Trainer, and Young Couple trainer types to the game.
Note that species pools and species filters for new trainer types are not yet finalized.
@Fontbane Fontbane added this to the 1.11.4 milestone Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants