Repository navigation
feat: Resolve issues #254, #301, #302, #303 - #309
Merged
parkerwinner merged 1 commit intoAug 28, 2026
Merged
Conversation
…kerwinner#302, parkerwinner#303 - parkerwinner#303: Add Architecture Decision Records (ADRs) in docs/adr/ - parkerwinner#301: Add multi-sig emergency pause mechanism (contracts/src/emergency_pause.rs) - parkerwinner#254: Add Cypress E2E tests for frontend (frontend/e2e/)
|
@devdianax Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves all 4 issues assigned to @devdianax:
Closes #254
Closes #301
Closes #302
Closes #303
#303 — Missing Architecture Decision Records (ADRs)
docs/adr/directory with ADR template format#302 — Incomplete API Documentation
backend/handlers/openapi.yamlanddocs/api/openapi.yaml:POST /auth/logout— Invalidate JWT tokenPOST /users— Register (alias for /auth/register)GET /exchange-rates— Get currency exchange rateGET/POST /payment-requests— List and create payment requestsGET /payment-requests/{id}— Get payment request detailsPOST /payment-requests/{id}/accept— Accept payment requestPOST /payment-requests/{id}/reject— Reject payment requestPOST /payment-requests/{id}/cancel— Cancel payment requestPOST /admin/rate-limit/reset— Admin rate limit resetGET /admin/rate-limit/view— Admin rate limit viewExchangeRate,PaymentRequest,CreatePaymentRequestAdmintag for admin-only endpoints#301 — Missing Emergency Pause Mechanism
contracts/src/emergency_pause.rswith multi-sig pause/unpause:vote_pause,vote_unpause,get_config,get_active_vote, etc.contracts/src/lib.rsto include the new module#254 — No E2E Tests for Frontend
frontend/cypress.config.jswith Cypress configurationfrontend/e2e/directory with comprehensive E2E tests:login.cy.js— Login form validation and error handlingremittance.cy.js— Remittance form, validation, submission, accessibilityinvoices.cy.js— Invoice viewer, loading states, empty statestransaction-history.cy.js— Filtering, searching, pagination, details modalnavigation.cy.js— Navigation, dark mode, language selector, skip linkse2e/support/commands.jswith custom Cypress commandsCI/CD Compatibility
.github/workflows/files