fix: use WALL_MIN_LENGTH constant to prevent ghost walls in sidebar#168
Merged
open-pascal merged 2 commits intopascalorg:mainfrom Mar 26, 2026
Merged
fix: use WALL_MIN_LENGTH constant to prevent ghost walls in sidebar#168open-pascal merged 2 commits intopascalorg:mainfrom
open-pascal merged 2 commits intopascalorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
Problem
WALL_MIN_LENGTHwas set to0.01(1cm), but the grid snaps in stepsof
0.5m. When a user placed a wall end point too close to the start,the snapped points would coincide, creating a wall node with effectively
zero length that still passed the minimum length check and got persisted
to IndexedDB — causing the ghost entry in the sidebar and a crash on reload.
Changes
WALL_MIN_LENGTHfrom0.01to0.5inwall-drafting.ts0.01 * 0.01checks inwall-tool.tsxwithWALL_MIN_LENGTH * WALL_MIN_LENGTHso all validations stay in syncRelated
Closes #103