check in go.mod/go.sum, add Dockerfile#20
Draft
derhuerst wants to merge 3 commits intopatrickbr:masterfrom
Draft
check in go.mod/go.sum, add Dockerfile#20derhuerst wants to merge 3 commits intopatrickbr:masterfrom
derhuerst wants to merge 3 commits intopatrickbr:masterfrom
Conversation
Contributor
Author
|
The Docker build currently fails with these errors: |
dolmen
suggested changes
Jun 17, 2025
| LABEL org.opencontainers.image.authors="Patrick Brosi <info@patrickbrosi.de>" | ||
| LABEL org.opencontainers.image.documentation="https://github.com/patrickbr/gtfstidy" | ||
| LABEL org.opencontainers.image.source="https://github.com/patrickbr/gtfstidy" | ||
| LABEL org.opencontainers.image.revision="v0.2" |
| @@ -1 +1,3 @@ | |||
| *.swp | |||
|
|
|||
| /gtfstidy No newline at end of file | |||
There was a problem hiding this comment.
Changes to .gitignore should be submitted separately.
| LABEL org.opencontainers.image.revision="v0.2" | ||
| LABEL org.opencontainers.image.licenses="GPL-2.0" | ||
|
|
||
| COPY --from=builder /usr/local/bin/gtfstidy /usr/local/bin/gtfstidy |
There was a problem hiding this comment.
What about storing the binary at root? /gtfstidy
| LABEL org.opencontainers.image.source="https://github.com/patrickbr/gtfstidy" | ||
| LABEL org.opencontainers.image.revision="v0.2" | ||
| LABEL org.opencontainers.image.licenses="GPL-2.0" | ||
|
|
| @@ -0,0 +1,9 @@ | |||
| module github.com/patrickbr/gtfstidy | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the binaries work great as a low-effort way to run
gtfstidyon some GTFS feeds, in some environments (e.g. CIs) using Docker is more straightforward.still missing:
This is a follow-up PR on #8, which I have accidentally closed.