Repository navigation
fix: drop the Cowork glow switch, claude.ai removed the glow - #302
Merged
patrickjaja merged 1 commit intoOct 29, 2026
Merged
Conversation
claude.ai no longer ships .cowork-hero-glow or its cowork-hero-glow-pulse keyframes: Cowork moved into the Claude tab and the old Cowork home went with it. The switch matched nothing, so remove add_feature_cowork_glow, its Community Features row, the bridge methods, the cdb-glow IPC handlers and the coworkGlow / coworkGlowOpacity template keys. A leftover key is ignored. Lowers EXPECTED_PATCH_COUNT 61 -> 60 (cc @patrickjaja).
Felitendo
marked this pull request as draft
October 29, 2026 09:51
Felitendo
marked this pull request as ready for review
October 29, 2026 09:59
Owner
|
Merged, thanks @Felitendo! Same here: I hadn't noticed the glow was gone upstream, so the switch would have kept looking like it worked while doing nothing. I merged it on top of #303 and set |
stratosjl
pushed a commit
to stratosjl/claude-desktop-extra
that referenced
this pull request
Oct 29, 2026
…rickjaja#303) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DSXWP5TYs8EMQ6Qbu3JNuR
stratosjl
pushed a commit
to stratosjl/claude-desktop-extra
that referenced
this pull request
Oct 29, 2026
Upstream moved to Claude Desktop v4.29.0 and dropped two patches; the overlay is re-fitted and the build follows the new package layout. - The Cowork glow is gone upstream (patrickjaja#302: claude.ai removed the glow it calmed). It leaves the Windows patch set, the Windows Community rows, the smoke test's startup lines and the docs; the overlay's hunk for add_feature_cowork_glow.nim is dropped. - ion-dist (the 3P setup window) ships as resources/ion-dist.asar since v4.29.0. build-windows.sh stages it like upstream's build-patched-tarball.sh: extract, run the nim-dir patch, repack to its place, read the archive back (every file packed, none unpacked). A resources/ion-dist folder (older packages) is still patched in place; both, neither, or an .unpacked layout fail the build. - On Windows the exe's integrity resource may list ion-dist.asar as well as app.asar. asar_integrity.py gains `records` and an archive name for fix-exe; the build rewrites ion-dist.asar's record when the exe has one (after checking its per-file integrity blocks) and logs the records it found. A record in an unexpected shape fails loudly. - Overlay: EXPECTED_TEST_HARNESSES is upstream's 55 plus the two Windows harnesses; the Windows DOM scenario also asserts that upstream's new Linux-only "Computer Use on a background display" row stays hidden (the row filter already keeps it out). Checked: the overlay applies to upstream/master and no upstream file is modified; the full harness run on the overlaid sources passes (57, 0 failed; the Nim-dependent ones skip without Nim here); the ion-dist sections of build-windows.sh run on fake packages for all six layouts (asar listed / unlisted in the exe, folder, both, none, .unpacked). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DSXWP5TYs8EMQ6Qbu3JNuR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: Made with Claude Opus 5.5, built and tested locally
Follow-up to #210: the "Calm the Cowork glow" switch no longer does anything, because claude.ai dropped the glow it holds still.
Why
.cowork-hero-glowand@keyframes cowork-hero-glow-pulseare in none of claude.ai's current stylesheets (the deploys served on 2026-10-27 and 2026-10-29), and no claude.ai script renders the class any more./coworkredirects to the product page). On the new homedocument.getAnimations()is empty, so nothing is left pulsing.coworkGlow, so it looks like it works while it changes nothing.What changed
patches/community/add_feature_cowork_glow.nimremoved,EXPECTED_PATCH_COUNT61 -> 60. @patrickjaja, AGENTS.md wants you on a lowered count.glowRead/glowSetbridge methods and thecdb-glow:*handlers are gone.coworkGlowandcoworkGlowOpacityare dropped from the generated.jsoncanddocs/claude-desktop-extra.jsonc. A leftover key is ignored.Tests
test-extra-settings-dom.mjs: 2524 passed, 0 failed. The glow assertions are gone. The two "this switch is not in that panel" checks use the Panel tabs switch now, and the section filter check types "source control" instead of "motion" (inverted once to confirm it runs).run-feature-tests.sh core10/10 andcommunity16/16,check-jsonc-template-sync.shmatches,makebuilds every patch.build-patched-tarball.shagainst the official 4.29.0.deb(GPG and SHA256 verified): absorption probeACTIVE=60; blocking=0, all 60 patches applied, JavaScript syntax validation passed.This touches the same count lines as #303 (the autoscroll removal). Whichever lands second needs
EXPECTED_PATCH_COUNT = 59and a rebase of the README count line; I'll do that.