Skip to content

Fix rate limiting by reusing global session cookies #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uprightbass360 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix rate limiting by reusing global session cookies #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions Plugins/SiriusXM/Bin/sxm.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,17 +403,16 @@ sub new {
# Get or create cookie jar for a specific channel
sub get_channel_cookie_jar {
my ($self, $channel_id) = @_;

# If no channel_id specified, use global cookie jar for backward compatibility
return $self->{ua}->cookie_jar unless $channel_id;

# Create channel-specific cookie jar if it doesn't exist
if (!exists $self->{channel_cookies}->{$channel_id}) {
$self->{channel_cookies}->{$channel_id} = HTTP::Cookies->new;
main::log_debug("Created new cookie jar for channel: $channel_id");
}

return $self->{channel_cookies}->{$channel_id};

# Always reuse the global cookie jar for all channels.
# Per-channel cookie jars start empty, forcing a separate login call
# for each channel playback request. Rapid back-to-back logins to the
# SiriusXM API trigger server-side rate limiting (HTTP 500), which
# prevents both channel listing and stream playback from working.
# Sharing the global session avoids redundant authentication while
# still allowing the existing session-expiry/re-auth logic to handle
# token refreshes when needed.
return $self->{ua}->cookie_jar;
}

# Set the user agent to use a specific channel's cookie jar
Expand Down