Maven dependency updates

[sebady]

Add exclusions for some maven dependencies to reduce duplicate
classes in classpath.

[TexanHogman]

@sebady doesn't make sense to be to exclude in this project based upon how we may assemble this later with Tomcat. The exclusion should come at a higher level

[sebady]

There is already a direct tomcat dependency here via org.springframework.boot:spring-boot-starter-web -> org.springframework.boot:spring-boot-starter-tomcat -> org.apache.tomcat.embed:tomcat-embed-core

[sebady]

If the goal is to have this starter be agnostic of tomcat / undertow than some of these existing dependencies will need to be reworked and some should be marked as provided. That's all beyond the scope of this pr though.

[fabiocarvalho777]

@sebady , I agree with @TexanHogman .

And, regarding the comment of yours below, not, that is not the goal of this starter. The goal of this starter is to integrate RESTEasy to Spring Boot. The tomcat dependency is brought by Spring Boot itself by default, not this starter, not RESTEasy. And the reason why Spring Boot does so is because it is "opinionated", and it prefers Tomcat as its "favorite" container.

If the goal is to have this starter be agnostic of tomcat / undertow ...

[fabiocarvalho777]

This can't be removed because it is needed for compilation time in in class ResteasyApplicationBuilder.java. As good practice, you should always have explicitly set in your pom files all dependencies you need for compilation time, instead of relying on eventual transitive dependencies.

[fabiocarvalho777]

This, and the following exclusion too, can't be done, because you are under the assumption that Tomcat will always be present, which is not true. Spring Boot applications can use other containers, like Jetty or Undertow.

[sebady]

Tomcat is always present via inclusion here of spring-boot-starter-web dependency. Would you consider removing spring-boot-starter-web as a dependency in this starter? Do we need it here as a direct maven dependency? It's removal would make these exclusions in this pr un-necessary and reduces the class conflicts on the class path.

[sebady]

closing. See this is an alternative pr #88