Skip to content

Fix light-mode command demo contrast#370

Merged
pbakaus merged 1 commit into
mainfrom
codex/light-mode-command-repro
Jul 14, 2026
Merged

Fix light-mode command demo contrast#370
pbakaus merged 1 commit into
mainfrom
codex/light-mode-command-repro

Conversation

@abdulwahabone

@abdulwahabone abdulwahabone commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Root cause

Dark-mode compatibility rules in home-kinpaku.css were not scoped to html.dark. When the light theme inverted --color-ink and --color-paper, those rules forced dark text onto dark CTA/avatar fills and pale warning text onto a pale warning panel.

Clarify (Light Mode)

Before After
Before: Clarify warning copy and primary action text disappear in light mode After: Clarify warning copy and primary action text are readable in light mode

Bolder (Light Mode)

Before After
Before: Bolder Learn More and accent copy fail light-mode contrast After: Bolder Learn More and accent copy meet light-mode contrast

Polish (Light Mode)

Before After
Before: Polish avatar initials and Edit Profile text disappear in light mode After: Polish avatar initials and Edit Profile text are readable in light mode

Note

Low Risk
CSS presentation and test-only changes in demo styling; no auth, data, or runtime logic.

Overview
Fixes light-mode contrast on homepage command split demos by scoping kinpaku compatibility overrides to the active theme instead of applying them in both modes.

Dark-only: Amber warning copy (#92400e and related) and primary controls using background: var(--color-ink) are remapped only under html.dark, so light mode keeps inline brown warning text and natural ink/paper CTA pairing.

Light-only: Demo labels that use color: var(--color-accent) now map to --ks-link-on-paper under html.light for readable gold accent text on paper.

Adds a docs integrity test that renders clarify/quieter/bolder/polish demos, asserts expected CTA markup, and guards that home-kinpaku.css contains theme-scoped selectors and no unscoped amber/ink overrides.

Reviewed by Cursor Bugbot for commit b1c8fc3. Bugbot is set up for automated code reviews on this repo. Configure here.

Scope dark compatibility rules to dark mode and guard the homepage and docs theme contracts.

AI-assisted-by: OpenAI Codex
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying impeccable with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1c8fc3
Status: ✅  Deploy successful!
Preview URL: https://a797ca14.impeccable-2rv.pages.dev
Branch Preview URL: https://codex-light-mode-command-rep.impeccable-2rv.pages.dev

View logs

@abdulwahabone abdulwahabone marked this pull request as ready for review July 14, 2026 13:39
@abdulwahabone abdulwahabone requested a review from pbakaus as a code owner July 14, 2026 13:39
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes light-mode contrast for command demos on the home page. The main changes are:

  • Dark-mode-only scoping for amber warning text overrides.
  • Dark-mode-only scoping for var(--color-ink) CTA fill overrides.
  • A light-mode accent text override for small demo labels on paper.
  • Tests that keep the demo markup and theme CSS selectors aligned.

Confidence Score: 5/5

Safe to merge with minimal risk.

The changes are narrow CSS selector updates with tests for this change, and no blocking issues were found.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • Ran bun test tests/docs-integrity.test.js and confirmed all tests passed (3 tests, 18 expectations).
  • Verified the capture log shows the affected UI text across Clarify, Bolder, and Polish demos: Clarify shows Delete this project? and Save and Continue; Bolder shows Introducing Our Product, A solution for modern teams, and Learn More; Polish shows JD and Edit Profile.
  • Compared before/after screenshots for the Clarify, Bolder, and Polish demos and confirmed the after-state images render readable copy and CTAs.
  • Collected and cataloged visual and runtime artifacts to support reviewer inspection of the changes.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
site/styles/home-kinpaku.css Scopes command demo contrast overrides to dark mode and adds a light-mode accent text override for affected demo labels.
tests/docs-integrity.test.js Adds tests that keep affected demo markup and theme CSS selector expectations aligned.

Reviews (1): Last reviewed commit: "Fix light-mode command demo contrast" | Re-trigger Greptile

@pbakaus pbakaus left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That one has bothered me :)

@pbakaus pbakaus merged commit 8259c28 into main Jul 14, 2026
13 checks passed
@pbakaus pbakaus deleted the codex/light-mode-command-repro branch July 14, 2026 14:53
mp3wizard added a commit to mp3wizard/impeccable that referenced this pull request Jul 15, 2026
New upstream features:
- Fix light-mode command demo contrast (pbakaus#370)
- chore(deps): bump bun-minor-and-patch group ×10 (pbakaus#368)
- Base sheriff stale clock on blocker age (pbakaus#364)

Security findings: 0 secrets, 0 dependency CVEs, 0 Semgrep findings. mcps-audit 1360 findings reviewed as heuristic false positives (execSync/delete/join idioms), consistent with prior cycles.
Security fixes: none required; bun.lock re-synced after upstream dep bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants