Fix light-mode command demo contrast#370
Merged
Merged
Conversation
Scope dark compatibility rules to dark mode and guard the homepage and docs theme contracts. AI-assisted-by: OpenAI Codex
Deploying impeccable with
|
| Latest commit: |
b1c8fc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a797ca14.impeccable-2rv.pages.dev |
| Branch Preview URL: | https://codex-light-mode-command-rep.impeccable-2rv.pages.dev |
Greptile SummaryThis PR fixes light-mode contrast for command demos on the home page. The main changes are:
Confidence Score: 5/5Safe to merge with minimal risk. The changes are narrow CSS selector updates with tests for this change, and no blocking issues were found. No files require special attention.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "Fix light-mode command demo contrast" | Re-trigger Greptile |
pbakaus
approved these changes
Jul 14, 2026
pbakaus
left a comment
Owner
There was a problem hiding this comment.
Nice! That one has bothered me :)
mp3wizard
added a commit
to mp3wizard/impeccable
that referenced
this pull request
Jul 15, 2026
New upstream features: - Fix light-mode command demo contrast (pbakaus#370) - chore(deps): bump bun-minor-and-patch group ×10 (pbakaus#368) - Base sheriff stale clock on blocker age (pbakaus#364) Security findings: 0 secrets, 0 dependency CVEs, 0 Semgrep findings. mcps-audit 1360 findings reviewed as heuristic false positives (execSync/delete/join idioms), consistent with prior cycles. Security fixes: none required; bun.lock re-synced after upstream dep bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Dark-mode compatibility rules in
home-kinpaku.csswere not scoped tohtml.dark. When the light theme inverted--color-inkand--color-paper, those rules forced dark text onto dark CTA/avatar fills and pale warning text onto a pale warning panel.Clarify (Light Mode)
Bolder (Light Mode)
Polish (Light Mode)
Note
Low Risk
CSS presentation and test-only changes in demo styling; no auth, data, or runtime logic.
Overview
Fixes light-mode contrast on homepage command split demos by scoping kinpaku compatibility overrides to the active theme instead of applying them in both modes.
Dark-only: Amber warning copy (
#92400eand related) and primary controls usingbackground: var(--color-ink)are remapped only underhtml.dark, so light mode keeps inline brown warning text and natural ink/paper CTA pairing.Light-only: Demo labels that use
color: var(--color-accent)now map to--ks-link-on-paperunderhtml.lightfor readable gold accent text on paper.Adds a docs integrity test that renders clarify/quieter/bolder/polish demos, asserts expected CTA markup, and guards that
home-kinpaku.csscontains theme-scoped selectors and no unscoped amber/ink overrides.Reviewed by Cursor Bugbot for commit b1c8fc3. Bugbot is set up for automated code reviews on this repo. Configure here.