Address review comments: remove unused deps, fix imbalance handling, update comments#554
Merged
ebma merged 3 commits intoallow-native-token-teleport-to-assethubfrom Feb 27, 2026
Merged
Conversation
…lance properly Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable teleport of native token to Assethub
Address review comments: remove unused deps, fix imbalance handling, update comments
Feb 27, 2026
ebma
approved these changes
Feb 27, 2026
ebma
added a commit
that referenced
this pull request
Mar 27, 2026
* Adjust xcm_config.rs for Pendulum and allow teleport of PEN to assethub * Implement xcm-teleport pallet * Add xcm-teleport pallet to pendulum runtime * Adjust xcm-teleport pallet to deposit leftover DOT back into sovereign account * Adjust config in pendulum runtime * Implement teleport check-in and check-out logic in custom transactor * Implement teleport destination validation in custom transactor * Rename variables * Address review comments: remove unused deps, fix imbalance handling, update comments (#554) * Initial plan * Address review comments: remove unused deps, fix comment, handle imbalance properly Co-authored-by: ebma <6690623+ebma@users.noreply.github.com> * Clarify comment about refund limitations Co-authored-by: ebma <6690623+ebma@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ebma <6690623+ebma@users.noreply.github.com> * Revert UnitWeightCost change * Add minimum teleport amount to prevent griefing attacks * Add logic to convert between PEN and DOT price using onchain prices * Fix `vec!` missing * Deposit leftover DOT to beneficiary * Reduce MaxDotFeeAmount to 0.5 * Adjust stale code --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unresolved review comments from PR #553:
Changes
Removed unused
staging-xcm-executordependency frompallets/xcm-teleport/Cargo.tomland all feature lists (std, runtime-benchmarks) — not referenced in codeFixed critical security issue in
teleport_native_to_asset_hub: Previously burned tokens immediately before XCM validation/delivery, causing permanent fund loss on routing failures. Now:imbalancealive through validation and deliverydrop(imbalance)T::Currency::resolve_creating()on validation or delivery errorsUpdated comment in
runtime/pendulum/src/xcm_config.rs:338from "Teleporting is disabled" to accurately reflect restriction viaTrustedTeleportersRemoved unused import
use sp_std::vec;from palletLimitation
The refund mechanism only covers local routing failures. If the XCM message is successfully delivered but fails during execution on AssetHub, tokens remain burned (remote execution failures are not detectable at send time).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.