K8SPG-777 Fix the crash in ShouldCheckStandbyLag#1652
Open
Kajot-dev wants to merge 5 commits into
Open
Conversation
Signed-off-by: Jakub Jaruszewski <jjaruszewski@man.poznan.pl>
Kajot-dev
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents operator crashes when PerconaPGCluster.spec.crVersion is empty by making version comparisons fall back to the operator’s build version, which is especially relevant for callers like the standby-lag polling goroutine that may not run Default().
Changes:
- Update
PerconaPGCluster.Version()to useversion.Version()whenspec.crVersionis unset.
Comment on lines
+508
to
+512
| crVersion := cr.Spec.CRVersion | ||
| if crVersion == "" { | ||
| crVersion = version.Version() | ||
| } | ||
| return gover.Must(gover.NewVersion(crVersion)) |
Contributor
Author
There was a problem hiding this comment.
No, this only falls back with the assumption that the opeator will reconcile the cluster and set the version asynchronously. Falling back to version.Version() on non empty can introduce hard to find bugs. But a way to do it, would actually be a validation pattern on the CRD
Comment on lines
+508
to
+511
| crVersion := cr.Spec.CRVersion | ||
| if crVersion == "" { | ||
| crVersion = version.Version() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This test case would only work on e2e tests
Contributor
There was a problem hiding this comment.
we don't need to test ShouldCheckStandbyLag regression but it'd be great to add a simple unit test that covers PerconaPGCluster.Version() behavior
Contributor
Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
Kajot-dev
force-pushed
the
fix/crversion-crash
branch
from
2bf8219 to
ed73169
Compare
Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
Signed-off-by: jjaruszewski <jjaruszewski@man.poznan.pl>
Kajot-dev
force-pushed
the
fix/crversion-crash
branch
from
3a00214 to
4901a83
Compare
Collaborator
commit: 4199c53 |
egegunes
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
In K8SPG-777 a problem was fixed where a cluster resource with empty crVersion would crash the operator, by the operator setting it to version.Version() early in the reconciliation loop.
However in K8SPG-374 #1407 an independent
pollAndRequeueStandbysgoroutine was introduced which lists clusters and callsShouldCheckStandbyLag()->CompareVersion("2.9.0"), but the coroutine does not call.Default()so the operator crashes.Solution:
Instead of making the goroutine call
cr.Default(), let's simply fallback to a version.Version() whencrVersionis not set since we know that operator will set it to that value and have test for itCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability