PS-11203 Vector Index Syntax#5987
Open
percona-mhansson wants to merge 2 commits into
Open
Conversation
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
3 times, most recently
from
c055ddc to
bac48eb
Compare
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
from
bac48eb to
6f38434
Compare
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
2 times, most recently
from
a985587 to
96481cb
Compare
Vector indexes have the type (algorithm) SE_SPECIFIC, and we add a column option in the data dictionary saying `vector_index=1;` which gets picked up by dedicated code in the data dictionary and the handler part of InnoDB. In the SQL layer, the vector index is very much a thing; there is an `HA_KEY_ALG_VECTOR`, an `HA_VECTOR` and a `KEYTYPE_VECTOR`. Extra SQL is added to display the type of a vector index as VECTOR rather than SE_SPECIFIC.
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
4 times, most recently
from
f0e62ee to
3c65f43
Compare
Adding the syntax `TYPE <ident> WITH ( <ident> = <ident>...) ` to index creation syntax. E.g.: `CREATE VECTOR INDEX <name> ( <table> ) TYPE hnsw WITH ( M = 6 )` The syntax in the `WITH` list, christened Index Construction Parameters in this commit, must be verified by the storage engine. There were no hooks for this in InnoDB so one has been added in check_engine(). We have to do it fairly early so that we can prevent table creation in the DD in case of errors. Hence, the index type and parameter list are validated inside the storage engine using a new interface validate_engine_attributes(). In order to leave the DD table definitions unchanged, we employ a couple of hacks: The index construction parameters are stored as key-value pairs inside the index's `option` field. The are unpacked from there for `SHOW CREATE TABLE`. To do: We will probably still need a hook to handle the case of an already-existing table with invalid attributes; there are no hooks for this.
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
from
3c65f43 to
67722d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #6000