PS-11297 [trunk]: Avoid calling validate() in non-debug in rec_offs_*()#6043
Open
polchawa-percona wants to merge 1 commit into
Open
PS-11297 [trunk]: Avoid calling validate() in non-debug in rec_offs_*()#6043polchawa-percona wants to merge 1 commit into
polchawa-percona wants to merge 1 commit into
Conversation
https://perconadev.atlassian.net/browse/PS-11297 validate_rec_offset() in the rec_offs_*() helpers of rem0wrec was called unconditionally, including in non-debug builds where it does no useful work. Wrap these calls in ut_d() so they are compiled only in debug builds, removing the per-call overhead on release builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-11297
trunk equivalent of #6042 (and #5922 / #6041).
validate_rec_offset() in the rec_offs_*() helpers of rem0wrec was called
unconditionally, including in non-debug builds where it does no useful work.
Wrap these calls in ut_d() so they are compiled only in debug builds, removing
the per-call overhead on release builds.