Repository navigation
Set index on derived grouped views to group columns - #3282
Merged
Merged
Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived tables created from a
group_byView withgroup_rollup_mode: "flat"are now indexed by theirgroup_bycolumns, on both the creating client and on remote clients thatopen_table+view()them. With an index, upstream deletes that evict a group now emiton_remove(type"key") on the derived table and its replicas.Also fixes two engine bugs surfaced by the new specs:
View::m_column_onlywas never initialized (garbage__ID__/__ROW_PATH__decoding on codec-keyed tables), andt_streecould fail to add a row to an existing null group when the null's status flavor differed from the node's.Drivebys
VirtualServer:ViewDimensionsReqpanics (Option::unwrap()onNone) when aViewDeleteReqfor the same view is handled while it awaits the handler, and the wasm instance is unusable afterwards #3283