Fix clojure version and windows#16
Open
IamDrowsy wants to merge 2 commits into
Open
Conversation
added 2 commits
August 8, 2025 07:49
Trying to start a browser with clojure 1.11.1 fails with: Execution error (ClassCastException) at java.lang.Class/cast (Class.java:4067). Cannot cast wally.main$make_page$fn__2605$fn__2609 to java.util.function.Consumer when trying to set a function as .onClose handler. Switching to Clojure 1.12.1 fixes this.
Using `(java.net.URI. (str "file://" (.getAbsolutePath user-data-dir))` fails on windows because it results in a `"file://C:\\User\\...."` which is not a valid uri. As `user-data-dir` already is an `java.io.File` we can use `(.toURI user-data-dir)` which should be os independent.
Owner
|
Ok, let me take a look o/ Thanks |
Merged
pfeodrippe
pushed a commit
that referenced
this pull request
Jul 7, 2026
Addresses `ClassCastException` regression detailed in #16. (1.12, which added functional interface interop ([CLJ-2799](https://clojure.atlassian.net/browse/CLJ-2799)), is required for the current code to compile).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to try out this library but stumbled upon two issues:
ClassCastException in clojure 1.11.1
Trying to start a browser with clojure 1.11.1 fails with:
when trying to set a function as
.onClosehandler.Using clojure 1.12.1 as dependency fixes this
Error when using on windows
Using
(java.net.URI. (str "file://" (.getAbsolutePath user-data-dir))fails on windows because it results in a"file://C:\\User\\...."which is not a valid uri.As
user-data-diralready is anjava.io.Filewe can use(.toURI user-data-dir)which should be os independent.