Repository navigation
Version 0.17.13 - #200
Merged
Merged
Version 0.17.13#200
Conversation
There was a problem hiding this comment.
Pull request overview
Version bump to 0.17.13 that improves wear-detection handling at the end of a recording (no longer drops the trailing partial windows) and extends activity epoch-data saving to include sleep periods in addition to wake periods. The corresponding shipping/wear test fixture is reworked to exercise more realistic end-of-recording cases.
Changes:
- Wear detection: compute moving stats with
trim=False, propagate the last valid non-wear value into the trailing partial windows, and clip resulting wear stop indices totime.size - 1. - Activity: add a
'state'field ('wake'/'sleep') toepoch_data, plumbtimeinto_compute_sleep_activity_endpoints, and call_handle_epoch_dataduring sleep periods too. - Updated
tests/preprocessing/conftest.pywear fixture andmeson.buildversion to0.17.13.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| meson.build | Version bumped to 0.17.13 |
| src/skdh/preprocessing/wear_detection.py | Use untrimmed moving windows, fill trailing NaN windows with last valid value, clip wear stops to recording length |
| src/skdh/activity/core.py | Add state to epoch_data; pass time to _compute_sleep_activity_endpoints; record sleep-period epoch data |
| tests/preprocessing/conftest.py | Updated wear fixture to add end-of-recording wear bouts and rewrote shipping-criteria masking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+653
to
+660
| # handle saving the epoch data | ||
| self._handle_epoch_data( | ||
| n_wlen, | ||
| fs, | ||
| time[start:stop], | ||
| acc_metric, | ||
| 'sleep', | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes