Repository navigation
Version 0.17.18 - #205
Merged
Merged
Version 0.17.18#205
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Public output keys are removed in a patch release, and the new timing behavior lacks test coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds standardized gait timing context and updates the package version.
Changes:
- Adds absolute, relative, and datetime initial-contact fields.
- Renames day timing fields.
- Bumps version to 0.17.18.
File summaries
| File | Description |
|---|---|
src/skdh/gait/core.py |
Expands and renames gait timing outputs. |
meson.build |
Updates the package version. |
Review details
Suppressed comments (1)
src/skdh/gait/core.py:585
- Replacing
IC Timerather than preserving it as an alias silently breaks existing consumers of the gait result schema. The new timestamp fields can be added while retainingIC Timeas a deprecated alias, particularly because this release only increments the patch version.
"IC Timestamp",
"IC Rel Timestamp",
"IC Datetime",
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+571
to
+572
| "Day Start Datetime", | ||
| "Day End Datetime", |
Comment on lines
+716
to
+718
| gait["IC Datetime"] = self.convert_timestamps(gait["IC Timestamp"]) | ||
| # get the relative IC timestamps | ||
| gait["IC Rel Timestamp"] = gait["IC Timestamp"] - gait["Bout Starts"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes