Skip to content

Version 0.17.18 - #205

Merged
LukasAdamowicz merged 2 commits into
mainfrom
development
Sep 3, 2026
Merged

LukasAdamowicz merged 2 commits into
mainfrom
development

Conversation

@LukasAdamowicz

Copy link
Copy Markdown
Collaborator

Changes

  • Added more context time columns to gait output, standardized column names

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Public output keys are removed in a patch release, and the new timing behavior lacks test coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds standardized gait timing context and updates the package version.

Changes:

  • Adds absolute, relative, and datetime initial-contact fields.
  • Renames day timing fields.
  • Bumps version to 0.17.18.
File summaries
File Description
src/skdh/gait/core.py Expands and renames gait timing outputs.
meson.build Updates the package version.
Review details

Suppressed comments (1)

src/skdh/gait/core.py:585

  • Replacing IC Time rather than preserving it as an alias silently breaks existing consumers of the gait result schema. The new timestamp fields can be added while retaining IC Time as a deprecated alias, particularly because this release only increments the patch version.
                "IC Timestamp",
                "IC Rel Timestamp",
                "IC Datetime",
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/skdh/gait/core.py
Comment on lines +571 to +572
"Day Start Datetime",
"Day End Datetime",
Comment thread src/skdh/gait/core.py
Comment on lines +716 to +718
gait["IC Datetime"] = self.convert_timestamps(gait["IC Timestamp"])
# get the relative IC timestamps
gait["IC Rel Timestamp"] = gait["IC Timestamp"] - gait["Bout Starts"]
@LukasAdamowicz
LukasAdamowicz merged commit 5c65ba3 into main Sep 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants