-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add patroni_port field to database api #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does port 0 have meaningful semantics for Patroni on SystemD hosts, or should this be Minimum(1) since there's no random-port-assignment mechanism like Docker provides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout! Yes, it has the same meaning:
0will assign a random port. You're right that we can't rely on OS features to do that for us, so I'm building that feature. I've kept this description vague for now since I'm still working out the details, and I don't want it to be misleading if we need to cut a release before I'm done. We will also eventually add support for this field in Swarm because it's useful for deploying a proxy in front of the instances. That'll be a separate follow-up ticket.