Skip to content

Spoc-465: LR issue due to spock can't find relation #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danolivo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Spoc-465: LR issue due to spock can't find relation #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c66cf2e
Prevent debug_query_string from producing garbage in apply worker logs
danolivo Mar 9, 2026
aba4164
Fix stale local_tuple pointer in INSERT exception for missing relation
danolivo Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/spock_apply.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,6 +1226,13 @@ handle_insert(StringInfo s)
*/
xact_had_exception = true;
exception_command_counter++;

/*
* Clear the local tuple pointer if it was left over from a
* previous operation.
*/
exception_log_ptr[my_exception_log_index].local_tuple = NULL;

log_insert_exception(true, "Spock can't find relation", NULL,
NULL, NULL, "INSERT");
end_replication_step();
Expand Down Expand Up @@ -3259,6 +3266,12 @@ static void
execute_sql_command_error_cb(void *arg)
{
errcontext("during execution of queued SQL statement: %s", (char *) arg);
/*
* The errcontext above already includes the SQL statement, so clear
* debug_query_string to prevent it from appearing a second time in
* the LOG output.
*/
debug_query_string = NULL;
}

/*
Expand Down Expand Up @@ -3779,6 +3792,13 @@ spock_apply_main(Datum main_arg)
Assert(MySpockWorker->worker_type == SPOCK_WORKER_APPLY);
MyApplyWorker = &MySpockWorker->worker.apply;

/*
* The apply worker is not a regular backend and has no client query
* string. Initialize debug_query_string to NULL so that LOG reports
* do not print arbitrary memory contents.
*/
debug_query_string = NULL;

/* Setup synchronous commit according to the user's wishes */
SetConfigOption("synchronous_commit",
spock_synchronous_commit ? "local" : "off",
Expand Down