Repository navigation
Conversation
…gadmin-org#10552 The fix for pgadmin-org#10357 remounts the dialog form on Reset so that SQL editor values still waiting to come back through SchemaView are discarded. This spec types into an SQL field, removes the edit, types again and presses Reset before SchemaView has passed those values back, then checks that the original value is shown. Without the remount the editor keeps the last typed value.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughAdds a ChangesSQL reset regression coverage
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: adding a regression test for Reset discarding pending SQL editor values in dialogs. |
| Linked Issues check | |
The new SchemaDialogViewResetSQL.spec.js implements #10552. It initializes an SQL field with BEGIN END;, performs an edit that enables Reset, deletes and replaces the edit, presses Reset before th… |
| Out of Scope Changes check | |
The whole pull request adds only the regression test file for the behavior in #10552. The test directly covers the SchemaDialogView Reset remount behavior. No unrelated production or test changes ar… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
dpage
added a commit
that referenced
this pull request
Oct 13, 2026
…10552 (#10560) The fix for #10357 remounts the dialog form on Reset so that SQL editor values still waiting to come back through SchemaView are discarded. This spec types into an SQL field, removes the edit, types again and presses Reset before SchemaView has passed those values back, then checks that the original value is shown. Without the remount the editor keeps the last typed value.
Contributor
Author
|
Merged as 8f24dc3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemaDialogViewResetSQL.spec.js, which types into an SQL field in a dialog, removes the edit, types again and presses Reset before SchemaView has passed those values back, then checks the original value is shown.key={resetKey}remount added toSchemaDialogViewin Fix the cursor jumping to the start of SQL fields in dialogs when keys are pressed together. #10357 #10543. With the remount removed the spec fails, showingBEGIN yEND;instead ofBEGIN END;.Test only; no overlap with the files being changed for #10551.
Test plan
key={resetKey}removedCloses #10552
Summary by CodeRabbit