Repository navigation
Conversation
…e left-most. pgadmin-org#9130 rc-dock selects the tab to the right of a closed active tab, but falls back to the first tab when there is none, so closing the right-most tab scrolled the tab bar back to the start. Activate the right neighbour or, failing that, the left one before removing the tab, matching browsers. Closes pgadmin-org#9130
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughWhen ChangesTab Close Selection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the main change: selecting an adjacent tab instead of the left-most tab when the active tab closes. |
| Linked Issues check | |
Issue #9130 requires an adjacent tab to remain selected when the active tab closes. LayoutDocker.close() checks the active tab, focuses the immediate right tab, and otherwise focuses the immediate l… |
| Out of Scope Changes check | |
The reviewed changes are limited to LayoutDocker.close() and its focused Jest coverage. The implementation and tests directly support issue #9130. No unrelated behavior or files are included in the … |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
dpage
added a commit
that referenced
this pull request
Oct 15, 2026
Contributor
Author
|
Squashed and merged as 610cad0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the active tab selected the tab to its right, or the left-most tab when there was none, so closing the right-most tab scrolled the tab bar back to the start (rc-dock's default).
LayoutDocker.close()now activates the right neighbour or, failing that, the left one before removing the tab, matching Chrome. Closing an inactive tab leaves the selection alone, as before.Test plan
LayoutDocker.spec.js(right-most, middle, inactive and only-tab closes); the right-most case fails without the fix.DockLayoutin jsdom that the saved layout records the new active tab.Closes #9130
Summary by CodeRabbit