chore(deps): bump transitive lockfile resolutions surfaced by dependabot#9955
Merged
Conversation
Pure lockfile-only updates — no package.json changes. Dependabot surfaced these as separate PRs because they sit below pgAdmin's direct deps in the resolution tree, so the manifest-level bumps applied in #9954 did not pull them along. web/yarn.lock: - @babel/plugin-transform-modules-systemjs 7.29.0 -> 7.29.4 (#9923) - devalue 5.7.0 -> 5.8.1 (#9937) - fast-uri 3.1.0 -> 3.1.2 (#9922) - svelte 5.55.1 -> 5.55.8 (#9938) (5.55.8 supersedes the 5.55.7 dependabot was tracking when the PR opened; both are within the same ^5.0.0 range.) runtime/yarn.lock: - fast-uri 3.1.0 -> 3.1.2 (#9924) All resolutions stay within their existing semver ranges declared by the parent packages — no manifest constraints touched. Refreshed via `yarn up -R <pkg>` in each workspace. Verified: - jest: 140/0/0 suites, 824/0/0 tests - eslint (web): clean (silent) - eslint (runtime): clean (silent)
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 20, 2026
asheshv
added a commit
that referenced
this pull request
May 20, 2026
…ce tests (#9958) The shared polling helpers in: - web/pgadmin/tools/backup/tests/test_backup_utils.py - web/pgadmin/tools/import_export/tests/test_import_export_utils.py - web/pgadmin/tools/maintenance/tests/test_create_maintenance_job.py - web/pgadmin/tools/restore/tests/test_create_restore_job.py all share the same race that surfaced on macos-latest / pg16 in PR #9955's CI run: - Wait budget was 2.5s (5 iterations x 0.5s; maintenance used 5s). - The break condition was `execution_time' in the_process`, but `execution_time` is the elapsed time of a *running* bgprocess -- it is set before the wrapped pg_dump / pg_restore / psql / COPY actually finishes. The completion signal is `exit_code` becoming non-None. - So the helper could return control while the wrapped command was still running, and the next assertion -- e.g. `assert_equal(the_process['exit_code'] in [0, 1], True)` -- would fire on `None in [0, 1]`, i.e. `False != True`. Some scenarios masked the bug by listing `None` in their `expected_exit_code` set (a tell that someone noticed the polling was unreliable and worked around it by widening accepted exit codes). Scenarios that didn't include `None` were the ones that flaked. Fix all four helpers identically: - Poll for up to 60 iterations x 0.5s = 30s, generous enough for the slowest CI runner. - Break only when `the_process.get('exit_code') is not None`, the actual completion signal. - Narrow `except Exception` to `except StopIteration`, which is the only thing `next(...)` here can raise. No call-site changes needed; the helper contract (returns once the job is done; raises if the bgprocess never finished) is unchanged in spirit and strictly more reliable in practice. Verified: - pycodestyle on the four files: 0 violations. This fixes the failure observed in the macos-latest / pg16 leg of PR #9955's CI run (run 26154521710, job 76930277702), which was unrelated to that PR's lockfile-only changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure lockfile-only updates — no
package.jsonchanges. Dependabot opened these as separate PRs because they sit below pgAdmin's direct deps in the resolution tree, so the manifest-level bumps applied in #9954 did not pull them along.web/yarn.lock@babel/plugin-transform-modules-systemjsdevaluefast-urisvelte^5.0.0)runtime/yarn.lockfast-uriMethod
yarn up -R <pkg>in each workspace. All resolutions stay within the existing semver ranges declared by the parent packages — no manifest constraints touched.Test plan
yarn run test:js-once→ 140 / 0 / 0 suites, 824 / 0 / 0 testsyarn run linterin/web→ clean (silent)yarn run linterin/runtime→ clean (silent)gh pr diffFollow-up
These five dependabot PRs (#9922, #9923, #9924, #9937, #9938) can be closed once this lands.