Open
Conversation
Temporary push trigger so the new package-base and package-ci-base workflows fire off the feature branch; remove before merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
meskill
reviewed
Apr 24, 2026
| run: cargo fmt --all -- --check | ||
| - name: Clippy | ||
| working-directory: pgdog | ||
| run: cargo clippy |
Contributor
There was a problem hiding this comment.
we can cargo clippy --all-targets to check the tests as well 🧪
Comment on lines
+50
to
+64
| - { name: pgbench, script: integration/pgbench/run.sh } | ||
| - { name: schema-sync, script: integration/schema_sync/run.sh } | ||
| - { name: go, script: integration/go/run.sh } | ||
| - { name: js, script: integration/js/pg_tests/run.sh } | ||
| - { name: ruby, script: integration/ruby/run.sh } | ||
| - { name: java, script: integration/java/run.sh } | ||
| - { name: mirror, script: integration/mirror/run.sh } | ||
| - { name: sql, script: integration/sql/run.sh } | ||
| - { name: toxi, script: integration/toxi/run.sh } | ||
| - { name: rust, script: integration/rust/run.sh } | ||
| - { name: python, script: integration/python/run.sh } | ||
| - { name: complex, script: integration/complex/run.sh } | ||
| - { name: dry-run, script: integration/dry_run/run.sh } | ||
| - { name: copy-data, script: integration/copy_data/run.sh } | ||
| - { name: load-balancer, script: integration/load_balancer/run.sh } |
Contributor
There was a problem hiding this comment.
we can go even further and specify only name and infer the path from it
Contributor
There was a problem hiding this comment.
rename the file to integration to make it explicit?
Comment on lines
+15
to
+38
| files=( | ||
| Cargo.lock | ||
| Cargo.toml | ||
| .cargo/config.toml | ||
| pgdog/Cargo.toml | ||
| pgdog/build.rs | ||
| pgdog-config/Cargo.toml | ||
| pgdog-macros/Cargo.toml | ||
| pgdog-plugin/Cargo.toml | ||
| pgdog-plugin/build.rs | ||
| pgdog-postgres-types/Cargo.toml | ||
| pgdog-stats/Cargo.toml | ||
| pgdog-vector/Cargo.toml | ||
| ) | ||
|
|
||
| dirs=( | ||
| pgdog/src | ||
| pgdog-config/src | ||
| pgdog-macros/src | ||
| pgdog-plugin/src | ||
| pgdog-postgres-types/src | ||
| pgdog-stats/src | ||
| pgdog-vector/src | ||
| ) |
Contributor
There was a problem hiding this comment.
I bet we can use some grep/expansion magic here. But in that case we can touch unexpected things though won't break the cache when we add something new.
Comment on lines
+46
to
+48
| strategy: | ||
| fail-fast: false | ||
| matrix: |
Contributor
There was a problem hiding this comment.
oh, so cool, I wanted to do this as well, but I was staring in the lcov binary dances and the build sharing there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.