Repository navigation
fix(stream): hide the live/prerecorded switch once air time starts - #837
Merged
Merged
Conversation
The upload exists only before air time, but the show page kept the switch on air. A switch to prerecorded then only changed the label, and no set could ever play. From air time on, the strip shows the mode as text. Refs: #836
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The show page no longer shows the Live / Pre-recorded switch once air time has started. The upload exists only before air time, so a switch to pre-recorded on air only changed the label and no set could ever play. From air time on, the status strip shows the mode as text.
Found in the Step 0 smoke test: show 49 was created with its window already running, and after a short live take the host could pick pre-recorded but never upload.
Issue: #836
Validation:
npx vitest run: 193 passed. New:canSwitchMediaModeis true only inprep.npm run lint: ok.npm run typecheck: ok.npm run build: ok.prettier --checkflagsStatusStrip.vue, but only line 161 (announcements count), which already fails onmain. It is left as is.detect_changes: risk low, no affected flows. GitNexus has no symbol for.vuefiles;StatusStriphas one user,ShowDetailPage.vue.The host panel ships inside the backend image, so this reaches hosts with the next backend deploy.
Implementation and review
This is a fix to
main(Step 0, https://github.com/phaabe/live.moafunk.de/milestone/37), not architecture-epic work, so the epic fields do not apply.Epic: n/a
Executor: n/a
Lane: n/a
Reviewer: n/a
Leaf IDs: n/a
Cause.
useShowPhasehasprep(before air time),broadcast(until the end) andwrapup(after the end, or once a live recording exists).ShowDetailPagerendersPrepUploadInlineonly inprep, butStatusStripshowed the toggle inprepandbroadcast.Change.
showMediaMode.ts:canSwitchMediaMode(phase), true only forprep.StatusStrip.vue: the toggle needscanManage && canSwitchMediaMode(phase); otherwise the existing read-only mode text shows.Not in this PR. An upload during the window: the server would accept it (scheduler every 30 s, no lateness rule), but R0 (https://github.com/phaabe/live.moafunk.de/milestone/38) picks the mode at booking, as the flow defines it.