Milter protocol don't allow modification before SMFIC_BODYEOB

[k33nice]

In all methods of Milter except Body(*Modifier) (Response, error), passed *Modifier cannot be used except of accessing macros.
If try to make some modifications, for example:

func (mm *myMilter) RcptTo(from string, m *milter.Modifier) (milter.Response, error) {
    m.AddRecipient("test@mail.com")
    return milter.RespContinue, nil
}

Postfix perform milter_default_action and finish milter session.

So maybe better pass only macro to methods e.g.:

// interface.go
...
	RcptTo(string, *map[string]string) (Response, error)
...

// session.go
...
	case 'R':
		// envelope to address
		envto := ReadCString(msg.Data)
		return m.Milter.RcptTo(strings.Trim(envto, "<>"), &m.Macros)

...

[phalaaxx]

Hi,

I'm not really sure about that... I'm using Modifier.Quarantine in SMFIC_EOH (Headers) and it works pretty well there. Have a look at https://github.com/phalaaxx/ratemilter/blob/master/main.go#L59 - I'm using this for several months in a production mail server and it works.
I think some Modifier methods could be used everywhere, thus I think it's probably better if it stays this way. Maybe it would be helpful to have a more precise documentation which states exactly which modifiers are allowed in each callback. Or even use different modifier interfaces that only allow methods relevant to the callback.
I'll look again into the milter protocol documentation when I have some time to spare and update the readme file and/or code comments at least.

Bozhin

[k33nice]

Thanks for quick response!
I'm not sure about it too:) I decided so, cuz in the spec "modification action" mentioned only in SMFIC_BODYEOB

milter/milter-protocol.txt

Lines 133 to 134 in 1e2fbc8

	SMFIC_BODYEOB
	Modification action (multiple, may be none)

I've tried to perform m.Add/ChangeHeader in SMFIC_EOH (Headers) and without milter_default_action=accept in postfix config I have error in maillog from postfix

postfix/cleanup[29528]: 0545D47926: milter-reject: END-OF-MESSAGE from ... 4.7.1 Service unavailable - try again later; from=...

With milter_default_action=accept in config, after modification, milter session is finish in the same way as if it where "accept" action, even I trigger miter.RespContinue and have BodyChunk and Body method.

I've tried to use Modifier.Quarantine in Headers but milter session is also finished despite of I perform return milter.RespContinue, nil.
On the assumption of http://www.postfix.org/MILTER_README.html (The "quarantine" action is like "accept" but freezes the message in the "hold" queue), I think, that quarantine is like accept/reject action.
Postfix logged

postfix/cleanup[21685]: 7469A47927: milter-hold: END-OF-MESSAGE from ...: milter triggers HOLD action; from=...

after miter.Quarantine.

I'm not MTA expert so my assumptions may be wrong...