Skip to content

Closes #258 add rs_neuro and ft_neuro datasets - #260

Open
meilinjiang wants to merge 16 commits into
mainfrom
258_add_rs_ft_neuro
Open

meilinjiang wants to merge 16 commits into
mainfrom
258_add_rs_ft_neuro

Conversation

@meilinjiang

@meilinjiang meilinjiang commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaversesdtm site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

To create the website for the content of this PR add "[create website]" to the title of the pull request.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
pharmaversesdtm 0% ❌
Summary 0% (0 / 41) ❌

@MilesAlmond

Copy link
Copy Markdown
Collaborator

Thank you @meilinjiang - review completed, and I really like the approach here, especially the checks. I just have a couple comments:

RS

  • To me, RSORRES and RSSTRESC are mixed up here, as I'd expect RSORRES to always hold the numerical value, and RSSTRESC to contain the qualitative character result (MILD, QUESTIONABLE etc.)
  • There aren't any 3/SEVERE cases in the data, I think it would be good to have some to cover all possibilities

FT

  • Similar to RS, I would expect FTORRES to contain the numerical value, and FTSTRESC to contain the "CORRECT"/"INCORRECT" values
  • My knowledge of MMSE is limited, but our smallest total here is 17, and I think it would be worth having a couple of totals <= 10 to simulate severe AD. What do you think?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants