Skip to content

Closes #261 rs_onco_pcwg4: add rs_onco_pcwg4 dataset [create website] - #262

Open
bundfussr wants to merge 5 commits into
mainfrom
261_rs_onco_pcwg4
Open

bundfussr wants to merge 5 commits into
mainfrom
261_rs_onco_pcwg4

Conversation

@bundfussr

@bundfussr bundfussr commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaversesdtm site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

To create the website for the content of this PR add "[create website]" to the title of the pull request.

@bundfussr bundfussr linked an issue Oct 29, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
pharmaversesdtm 0% ❌
Summary 0% (0 / 41) ❌

@bundfussr
bundfussr requested a review from amitjaingsk October 29, 2026 14:05
@bundfussr bundfussr changed the title Closes #261 rs_onco_pcwg4: add rs_onco_pcwg4 dataset Closes #261 rs_onco_pcwg4: add rs_onco_pcwg4 dataset [create website] Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The website/documentation is available at https://pharmaverse.github.io/pharmaversesdtm/261_rs_onco_pcwg4/dev.

@sunkukedar sunkukedar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the rs_onco_pcwg4 dataset against the PCWG4 paper (Armstrong et al., JCO 2026;44:1249-1265). One structural issue to resolve before merging, plus a small cosmetic fix.

  1. PSMA-PET response reuses the OVRLRESP test code from the CT+bone combined response
    In data-raw/rs_onco_pcwg4.R, the testnames mapping gives both "Overall" and "PSMA_PET" the same RSTESTCD/RSTEST (OVRLRESP / "Overall Response"), distinguished only by RSCAT ("PCWG SCHER PROSTATE CANCER 2016" vs. "PSMA-PET"). The output CSV confirms this: every subject/visit gets two rows both coded RSTESTCD = OVRLRESP.
    PCWG4 is explicit that PSMA-PET is a separate, independently reported endpoint, not merged with the CT/bone combined response. Reusing the same test code means any consumer filtering RSTESTCD == "OVRLRESP" (the natural thing to write for BOR/ADRS derivation) will silently pull in both responses per visit unless it also filters on RSCAT.
    Suggest giving PSMA-PET its own code, consistent with how BONERESP/SFTSRESP each already get one — e.g. RSTESTCD = "PETRESP", RSTEST = "PSMA-PET Response", keeping RSCAT = "PSMA-PET".

  2. Leftover PCWG3 labels
    data-raw/rs_onco_pcwg4.R line 2 (# Description: RS Oncology dataset using PCWG3 criteria) and the dataset attribute attr(rs_onco_pcwg4, "label") <- "Disease Response (PCWG3)" still say PCWG3 — looks like residue from adapting rs_onco_pcwg3.R. The object name, roxygen title, NEWS.md, and sdtms-specs.json all correctly say PCWG4; these two should match.

Everything else looks right — the PSMA-PET categories (CR/NON-CR/NON-PD/PDu/PD/NE, no PR/SD) match PCWG4's scale exactly, and keeping the soft-tissue/bone logic unchanged from PCWG3 is correct per the paper.

@bundfussr

Copy link
Copy Markdown
Collaborator Author

Hi @sunkukedar , thanks for your review. I've fixed the labels.

Regarding the RSTESTCD value, I agree that a separate test code would be better. However, I'm not sure if we should use "PETRESP". For RSTESTCD CDISC defines the codelist C96782 which has the following values:

CDISC Submission Value CDISC Synonym(s) CDISC Definition
ANATRESP Anatomic Response An assessment of the anatomic response (based on changes in size of anatomic structures) of the disease to the therapy.
BESTRESP Best Overall Response; Best Response An assessment of the most clinically favorable overall response of the disease to the therapy.
BMIVLIND Bone Marrow Involvement Indicator An indication as to whether disease is present in the bone marrow.
BMRRESP Bone Marrow Response An assessment of the disease response to therapy within the bone marrow.
BONERESP Bone Response An assessment of the bone response of the disease to the therapy.
CLINRESP Clinical Response An assessment of the clinical response of the disease to the therapy.
CPRFSTAT Clinical Performance Status An assessment of the clinical performance, measured by a rating or scale, as a condition of disease response to therapy. (NCI)
CYTORESP Cytogenetic Response An assessment of the cytogenetic response of the disease to the therapy.
DRCRIND Disease Recurrence Indicator An indication as to whether disease recurrence occurred.
HEMARESP Hematologic Response An assessment of the hematologic response of the disease to the therapy.
LIVRRESP Liver Response An assessment of the disease response to therapy within the liver.
METBRESP Metabolic Response An assessment of the metabolic response of the disease to the therapy.
METSIND Metastatic Indicator An indication as to whether disease metastasis has occurred.
MJPTHIND Major Pathological Response Indicator An indication as to whether major pathological response occurred.
MNPTHIND Minor Pathological Response Indicator An indication as to whether minor pathological response occurred.
MOLRESP Molecular Response An assessment of the molecular response of the disease to the therapy.
MRDIND Minimal Residual Disease Indicator; MRD Indicator An indication as to whether the subject has minimal residual disease.
MRDRESP Minimal Residual Disease Response; MRD Response An assessment of the minimal residual disease response of the disease to the therapy.
MRPHRESP Morphologic Response An assessment of the morphologic response of the disease to the therapy.
NEWLIND New Lesion Indicator An indication as to whether new lesions are present, in comparison to a previous timepoint.
NEWLPROG New Lesion Progression An assessment of the equivocality of disease progression based on a newly identified lesion.
NEWLWIND New Lesion Worsening Indicator An indication as to whether the previously identified new lesions are showing signs of worsening.
NTERESP Non-Target Enhancing Response An assessment of the response to the therapy of the non-target enhancing disease. (NCI)
NTLWIND Non-Target Lesion Worsening Indicator An indication as to whether non-target lesions, which have previously shown progression, are showing additional signs of worsening.
NTNERESP Non-Target Non-Enhancing Response An assessment of the response to the therapy of the non-target non-enhancing disease. (NCI)
NTRGRESP Non-target Response An assessment of the response of a non-target lesion(s) to the therapy.
OVRLRESP Overall Response An assessment of the overall response of the disease to the therapy. (NCI)
PATHRESP Pathologic Response An assessment of the pathologic response of the disease to the therapy.
RDIORESP Radiologic Response An assessment of the radiologic response of the disease to the therapy.
SFTSRESP Soft Tissue Response An assessment of the soft tissue response of the disease to the therapy.
SPLNRESP Spleen Response An assessment of the disease response to therapy within the spleen.
STRUSTAT Steroid Use Status An assessment of steroid usage as a condition of disease response to therapy. (NCI)
SYMPTDTR Symptomatic Deterioration A global deterioration of health status providing evidence of disease progression not covered by disease response criteria (eg. RECIST).
TMRESP Tumor Marker Response An assessment of disease response to therapy based on tumor marker measurement.
TRGRESP Target Response An assessment of the response of a target lesion(s) to the therapy.

Maybe we should use on of those?

We can discuss in the meeting tomorrow.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: PCWG4 test data for admiralonco

2 participants